Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 FPM: Missing curl tracking #355

Closed
adri opened this issue Mar 3, 2022 · 7 comments
Closed

PHP 8.1 FPM: Missing curl tracking #355

adri opened this issue Mar 3, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@adri
Copy link

adri commented Mar 3, 2022

Description

After deploying the New Relic agent v9.19.0 with PHP 8.1 we noticed that the curl integration seems to not track durations and throughput anymore when running under FPM. It works still when in the context of PHP CLI (worker). This worked under PHP 8.1 using New Relic Agent version v9.19.0.

Steps to Reproduce

  1. Upgrade to v9.19.0 using PHP 8.0 ✅ curl tracked correctly
  2. Upgrade to v9.19.0 using PHP 8.1 ❌ curl not tracked correctly.

Expected Behavior

Curl response duration tracking should stay the same as under PHP 8.1.

Relevant Logs / Console output

Screen Shot 2022-03-03 at 14 59 41

However, throughput didn't change:
Screen Shot 2022-03-03 at 15 10 31

Your Environment

  • Offical php:8.1.3-fpm Docker image with Linux 5.4.172-90.336.amzn2.x86_64 x86_64 GNU/Linux
@adri adri added the bug Something isn't working label Mar 3, 2022
@zsistla
Copy link
Contributor

zsistla commented Mar 3, 2022

@adri Thanks for bringing this to our attention.
We'll be investigating it on our side and will reach out if we need any clarifications/additional info from you.

@adri Which framework were you using to send/handle your curl traffic.

@zsistla
Copy link
Contributor

zsistla commented Mar 3, 2022

Hi @adri ,
If you could provide a snippet of the code that makes the curl call and also the framework being used for the website, it'll help us reproduce/debug this.
:) Thanks!

@adri
Copy link
Author

adri commented Mar 4, 2022

@zsistla Good point! I assumed that we use a released version of Guzzle (which uses afaik curl_multi_exec). However, we seem to use a version that fixes an PHP 8.1 deprecation that is not merged and released yet.

Could this be related?

@adri
Copy link
Author

adri commented Mar 4, 2022

I guess this issue can be closed and only becomes relevant when this PR is actually merged.

@adri adri closed this as completed Mar 4, 2022
@zsistla
Copy link
Contributor

zsistla commented Mar 4, 2022

@aldri, oh interesting! Thanks for the PR link and the update on this.

@ostrolucky
Copy link

We use Guzzle 7.4.3 and we updated to PHP 8.1 , now after latest release it seems NR no longer accurately measures external calls

image

@fastyzfr1
Copy link

We recently upgraded to PHP 8.1 from 7.4 and all of our external calls are not being tracked. We are using Laravel 9.x which uses Guzzle as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants