Minor refactoring of daily logfile rolling job to support all platforms. #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1888 +/- ##
============================================
+ Coverage 70.66% 70.69% +0.02%
- Complexity 9876 9878 +2
============================================
Files 828 828
Lines 39848 39850 +2
Branches 6064 6065 +1
============================================
+ Hits 28160 28172 +12
+ Misses 8960 8951 -9
+ Partials 2728 2727 -1 ☔ View full report in Codecov by Sentry. |
meiao
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1884
Refactor of the
ClearExpiredLogsRunnableconstructor to remove the Path param. Uses an alternative method for grabbing the log file name and path.Update tests.
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks