Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletableFuture module for completeAsync #1882

Closed
kanderson250 opened this issue May 2, 2024 · 2 comments · Fixed by #1908
Closed

CompletableFuture module for completeAsync #1882

kanderson250 opened this issue May 2, 2024 · 2 comments · Fixed by #1908
Assignees
Labels
2 Story Point Estimate

Comments

@kanderson250
Copy link
Contributor

kanderson250 commented May 2, 2024

Description

From this spike #1741.

Spring 6 methods wrapped in a CompletableFuture and annotated with @Async don't hit our current instrumentation. This is because they call completeAsync on the CF, which was introduced with Java 9 and so isn't a part of our current modules for Java 8+.

Instrumenting completeAsync will entail creating a new CompletableFuture instrumentation module, applicable to JDK 9+.

Acceptance Criteria

Async calls made with Spring 6 are instrumented fully, and additional tests are added for completeAsync.

@kanderson250 kanderson250 added the 2 Story Point Estimate label May 2, 2024
@workato-integration
Copy link

@kanderson250 kanderson250 self-assigned this May 2, 2024
@kanderson250
Copy link
Contributor Author

Related GTSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Story Point Estimate
Projects
Status: Code Complete/Done
Development

Successfully merging a pull request may close this issue.

1 participant