Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka HTTP enhancement #1839

Open
kanderson250 opened this issue Apr 2, 2024 · 1 comment
Open

Akka HTTP enhancement #1839

kanderson250 opened this issue Apr 2, 2024 · 1 comment
Labels
2 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter

Comments

@kanderson250
Copy link
Contributor

While working on the new Pekko instrumentation, we noticed that with Pekko Http 1 (fork of Akka Http 10.2), it's possible for server routes to skirt our instrumentation.

As of Akka Http 10.2, the seal method in http.scaladsl.server.Route no longer applies to routes in all cases. An alternate method (toFunction) is sometimes called. Since our instrumentation uses seal as the entrypoint to wrap incoming requests and start transactions, routes that go through toFunction fail to report transactions.

This issue was demonstrated with Pekko Http 1.

Description

Verify that for apps using Akka Http 10.2, the existing instrumentation doesn't work.

Then add instrumentation as we have for Pekko Http 1 which captures routes in all cases (likely by instrumenting createAsyncHandler). Add a new AIT for Akka Http 10.2.

@kanderson250 kanderson250 added 2 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter labels Apr 2, 2024
@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Story Point Estimate apr-jun qtr Represents proposed work item for the Apr-Jun quarter
Projects
Status: In Quarter
Development

No branches or pull requests

1 participant