Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricNameFormats should use a bounded cache #1825

Open
jbedell-newrelic opened this issue Mar 28, 2024 · 1 comment
Open

MetricNameFormats should use a bounded cache #1825

jbedell-newrelic opened this issue Mar 28, 2024 · 1 comment
Labels
2 Story Point Estimate GTSE There is an associated support escalation with this issue.

Comments

@jbedell-newrelic
Copy link
Contributor

jbedell-newrelic commented Mar 28, 2024 •
edited by meiao

newrelic-java-agent/newrelic-agent/src/main/java/com/newrelic/agent/tracers/metricname/MetricNameFormats.java

Lines 21 to 23 in 4b53e4f

private static final Cache<MNFKey, MetricNameFormat> cmsToMnf = Caffeine.newBuilder()
.executor(Runnable::run)
.build();

If a customer were to create enough segments with extremely dynamic names, this cache could grow to an unreasonable size and appear to be a memory leak.
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-253913

@kford-newrelic kford-newrelic added the estimate Issue needing estimation label Mar 28, 2024
@kford-newrelic kford-newrelic added GTSE There is an associated support escalation with this issue. 2 Story Point Estimate and removed estimate Issue needing estimation labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 Story Point Estimate GTSE There is an associated support escalation with this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kford-newrelic @jbedell-newrelic