Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emergency JMX config for nested DOM with Solr 7+ #1814

Open
obenkenobi opened this issue Mar 22, 2024 · 1 comment
Open

Remove emergency JMX config for nested DOM with Solr 7+ #1814

obenkenobi opened this issue Mar 22, 2024 · 1 comment
Labels
on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter

Comments

@obenkenobi
Copy link
Contributor

obenkenobi commented Mar 22, 2024

Description

With respect to the previous issue with enhancing JMX metrics with Solr 7 and up, and the associated pull request, a new config was added to disable the feature. This is due to some new internal string formatting added to handle MBeans containing an object name with nested dom.

The new configuration here is as follows:

yaml:

# newrelic.yml snippet
common: &default_settings
  jmx:
    enable_iterated_objectname_Keys: true # default is true

system property:

-Dnewrelic.config.jmx.enable_iterated_objectname_Keys=true

environment variable:

NEW_RELIC_JMX_ENABLE_ITERATED_OBJECTNAME-KEYS=true

Acceptance Criteria

To remove the new JMX configuration as shown above and simplify any conditional checks and updates to tests due to the new config.

Additional context

This is not an officially documented configuration as the expectation here is anyone using Solr 7 and up will not need to disable the new internal syntax. Assuming no new issue pops up related to that syntax, we should later remove the config.

@workato-integration
Copy link

@obenkenobi obenkenobi changed the title Remove emergency JMX config Remove emergency JMX config for nested DOM with Solr 7+ Mar 22, 2024
@obenkenobi obenkenobi added on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter technical debt and removed technical debt labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter
Projects
None yet
Development

No branches or pull requests

1 participant