Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NEW_RELIC_ERROR_COLLECTOR_EXPECTED_ERROR_CODES and NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODES environment variables #2181

Closed
dggmez opened this issue Jan 10, 2024 · 2 comments · Fixed by #2487
Labels
community To tag external issues and PRs

Comments

@dggmez
Copy link

dggmez commented Jan 10, 2024

Is your feature request related to a problem? Please describe.

We can only use either .NET configuration providers and environment variables to configure the New Relic agent. Right now, the error collector can only be configured through a newrelic.config file.

Feature Description

I would like to see support the NEW_RELIC_ERROR_COLLECTOR_EXPECTED_ERROR_CODES and NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODES environment variables. Those environment variables are already supported by the Node.js agent:

https://docs.newrelic.com/docs/apm/agents/nodejs-agent/installation-configuration/nodejs-agent-configuration/

Describe Alternatives

I mean, if the error collector could be configure through any .NET configuration provider it would also work. We could set the configuration through either environment variables, KeyVault, file configuration (appsettings.json), etc. and to be honest that's the way we configure everything through .NET configuration providers except New Relic :(. Sadly that alternative is NOT supported either:

https://forum.newrelic.com/s/hubtopic/aAX8W0000008ci1WAA/net-configure-net-agent-error-collector-with-appsettingsjson

Additional context

I hope everything is clear and no additional context is needed.

Priority

Please help us better understand this feature request by choosing a priority from the following options:
[Really Want]

@workato-integration
Copy link

@github-actions github-actions bot added the community To tag external issues and PRs label Jan 10, 2024
@tippmar-nr
Copy link
Member

@dggmez Thanks for creating this feature request. We have a few other existing requests to support environment variables for configuration, and we're looking at adding support for all configuration options via environment variables, though there's currently no timetable for that effort. We'll keep your request in our backlog and update it when we make progress.

@workato-integration workato-integration bot changed the title Support NEW_RELIC_ERROR_COLLECTOR_EXPECTED_ERROR_CODES and NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODES environment variables CLONE - Support NEW_RELIC_ERROR_COLLECTOR_EXPECTED_ERROR_CODES and NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODES environment variables Feb 21, 2024
@workato-integration workato-integration bot changed the title CLONE - Support NEW_RELIC_ERROR_COLLECTOR_EXPECTED_ERROR_CODES and NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODES environment variables Support NEW_RELIC_ERROR_COLLECTOR_EXPECTED_ERROR_CODES and NEW_RELIC_ERROR_COLLECTOR_IGNORE_ERROR_CODES environment variables Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs
Projects
None yet
2 participants