Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore alternative MassTransit queue naming strategies #2061

Open
nr-ahemsath opened this issue Nov 13, 2023 · 1 comment
Open

Explore alternative MassTransit queue naming strategies #2061

nr-ahemsath opened this issue Nov 13, 2023 · 1 comment

Comments

@nr-ahemsath
Copy link
Member

Describe the story, please be clear on scope of the story.

This story will be good for a tech debt/bug smash milestone.

In MassTransit instrumentation, we are currently using the SourceAddress property of the context data object to get the queue name. However, as seen in #2055, this property can be null in some scenarios.

In those same scenarios, there is a DestinationAddress property which is not null, and contains some properties/fields which look like they could make sensible queue names:

context.DestinationAddress
{rabbitmq://localhost/NoMTEnvelopeRepro:NoMTEnvelopeRepro}
    AbsolutePath: "/NoMTEnvelopeRepro:NoMTEnvelopeRepro"
    AbsoluteUri: "rabbitmq://localhost/NoMTEnvelopeRepro:NoMTEnvelopeRepro"
    LocalPath: "/NoMTEnvelopeRepro:NoMTEnvelopeRepro"
    OriginalString: "rabbitmq://localhost/NoMTEnvelopeRepro:NoMTEnvelopeRepro"
    PathAndQuery: "/NoMTEnvelopeRepro:NoMTEnvelopeRepro"

Some more testing would be needed to see if this property is always non-null and if the values are sensible in all scenarios we wish to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant