Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent obfuscates commented data in SQL queries #1856

Open
rchekryzhov opened this issue Aug 20, 2023 · 2 comments
Open

Agent obfuscates commented data in SQL queries #1856

rchekryzhov opened this issue Aug 20, 2023 · 2 comments
Labels
community To tag external issues and PRs feature request To tag an issue after triage that is a feature instead of TD

Comments

@rchekryzhov
Copy link

Description
Agent obfuscates comments in SQL queries:

-- File: /build/source/Foo/Bar.cs:127
select id from bar 

turns into:

-- File: /build/source/Foo/Bar.cs:?
select id from bar 

Expected Behavior
Commented SQL should not be obfuscated

For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):

@rchekryzhov rchekryzhov added the bug Something isn't working label Aug 20, 2023
@workato-integration
Copy link

@github-actions github-actions bot added the community To tag external issues and PRs label Aug 20, 2023
@jaffinito
Copy link
Member

Hi @rchekryzhov thanks for letting us know about this. We currently don't have an specific log for handling comments in SQL queries, but nothing is really preventing us from doing so. We had a quick discussion as a team about this and there are some questions about potential sensitive information being put comments so we don't want to just not obfuscate them. Some exploration of different approaches is warranted to see what works best.

This makes this less of a bug and more of a feature request. I am going to get this setup as one so it can be reviewed.

@jaffinito jaffinito added feature request To tag an issue after triage that is a feature instead of TD and removed bug Something isn't working labels Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs feature request To tag an issue after triage that is a feature instead of TD
Projects
None yet
Development

No branches or pull requests

2 participants