Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration for ms sql server with newrelic #425

Merged
merged 5 commits into from Jun 29, 2022

Conversation

ishahid91
Copy link
Contributor

Added intergation for ms sql server

Links

Details

Added integration for ms sql server to show database transactions on new relic. I have used the similar approach which is used in other integrations. I have added the relevant unit test and example as well which I tested on my local with sql server.

Added intergation for ms sql server
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2021

CLA assistant check
All committers have signed the CLA.

Copy link

@disiqueira-talabat disiqueira-talabat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

@RichVanderwal
Copy link
Contributor

Thanks, @ishahid91 , for this PR! We'll be looking at it and considering it for inclusion in the Go Agent. It looks quite straightforward, and we're hoping to test it against a real MS SQL server soon!

Note that development generally slows down at the end of the calendar year, so our team most likely won't be looking closely at it until a few weeks have passed.

@ishahid91
Copy link
Contributor Author

Thanks @RichVanderwal for looking at the PR and considering it to include in Go Agent. I am looking forward to get it included in Go Agent ASAP as this will help us and many other teams to monitor MS SQL Server for many critical Go services.

@ishahid91
Copy link
Contributor Author

Hi @RichVanderwal, Any update on the review ? Looking forward to get it merged so that we can integrate it into our production services.

@ishahid91
Copy link
Contributor Author

@RichVanderwal gentle reminder.

@RichVanderwal RichVanderwal added this to Awaiting User Input in Go Engineering Board via automation Feb 14, 2022
@RichVanderwal RichVanderwal moved this from Awaiting User Input to Triage in Go Engineering Board Feb 14, 2022
@Ak-x Ak-x moved this from Triage to In progress in Go Engineering Board Feb 15, 2022
@Ak-x Ak-x moved this from In progress to Code Review in Go Engineering Board Feb 15, 2022
@Ak-x Ak-x moved this from Code Review to To Do in Go Engineering Board Feb 15, 2022
@Ak-x Ak-x added the pr pull request available label Feb 15, 2022
@Ak-x Ak-x moved this from To Do to Ice Box in Go Engineering Board Feb 15, 2022
@iamemilio iamemilio changed the base branch from master to develop May 25, 2022 20:36
@iamemilio
Copy link
Contributor

@ishahid91 Hi, are you still interested in merging this? We will help you :)

@ishahid91
Copy link
Contributor Author

Yes @iamemilio Can you please help merge this PR.

@iamemilio
Copy link
Contributor

Overall, it looks good. Could you remove the dependency on ms-sql in the v3/go.mod file and verify that the changes still work?

@ishahid91
Copy link
Contributor Author

Hi @iamemilio I have made the requested changes

@iamemilio
Copy link
Contributor

Looks good. I will try to run this just to make sure everything checks out. Once the test is happy, and I run it, I think this will be good to go

@iamemilio
Copy link
Contributor

@ishahid91 I was able to run this. Once you clean up the go lint errors, this is ready to merge: https://github.com/newrelic/go-agent/runs/6757623643?check_suite_focus=true

Thanks for submitting this, and thank you for being patient with us while we continue to grow our team!

@ishahid91
Copy link
Contributor Author

@iamemilio fixed the linting issue, can you please run once again to verify. Thank you for your time and making it ready to merge :)

Copy link
Contributor

@iamemilio iamemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ishahid91
Copy link
Contributor Author

@iamemilio Thanks for approving the PR. When I can expect this PR to be merged ?

@iamemilio
Copy link
Contributor

It will very likely be merged in time for the next release!

@nr-swilloughby nr-swilloughby merged commit 74b16d1 into newrelic:develop Jun 29, 2022
Go Engineering Board automation moved this from Ice Box to Done Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr pull request available
Development

Successfully merging this pull request may close these issues.

None yet

7 participants