Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLM to new spec requirements for attribute truncation #595

Open
MadScienceZone opened this issue Nov 1, 2022 · 1 comment
Open
Assignees

Comments

@MadScienceZone
Copy link

The Go agent reports all CLM data regardless of length. However, since generally speaking transaction attributes may be no longer than 255 characters, these attributes will end up getting truncated if, e.g., a function or path name is over that length. However, a truncated file or function name is useless for subsequent use by CLM since the true, full name is missing.

Instead, implement the following logic to handle any cases where the CLM attributes would be too long:

For any given trace:

  • drop any CLM attribute if it's over 255 characters
  • if code.function doesn't exist or if the function name is over 255 characters, drop all CLM attributes
  • if code.function exists and both code.namespace and code.filepath are over 255 characters, drop all CLM attributes
@nr-swilloughby
Copy link
Contributor

Sorry, I was signed in from my personal github account when I posted that issue :/

@nr-swilloughby nr-swilloughby self-assigned this Nov 1, 2022
@nr-swilloughby nr-swilloughby added this to Awaiting User Input in Go Engineering Board via automation Nov 1, 2022
@nr-swilloughby nr-swilloughby moved this from Awaiting User Input to To Do in Go Engineering Board Nov 1, 2022
@nr-swilloughby nr-swilloughby moved this from To Do to In progress in Go Engineering Board Nov 9, 2022
@nr-swilloughby nr-swilloughby moved this from In progress to Code Review in Go Engineering Board Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants