Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiddlewareWithConfig method in comment but not exists #586

Open
roger-codina opened this issue Sep 29, 2022 · 0 comments
Open

MiddlewareWithConfig method in comment but not exists #586

roger-codina opened this issue Sep 29, 2022 · 0 comments

Comments

@roger-codina
Copy link

Hi guys,

If I am not mistaken, I think that this comment refers to an old method or a not implemented one:

// e.Use(nrecho.MiddlewareWithConfig(nrecho.Config{App: app}))

The only way to create the middleware handler is calling the Middleware function using a *newrelic.Application as the first argument and passing as variadic arguments ConfigOption types.

So, I think that the comment should be fixed to document the current behaviour of the function or implement that method :)

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant