Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeStream Integration Code-Level Metrics for Transactions #541

Merged
merged 12 commits into from Jul 28, 2022
Merged

CodeStream Integration Code-Level Metrics for Transactions #541

merged 12 commits into from Jul 28, 2022

Conversation

nr-swilloughby
Copy link
Contributor

This adds code-level metrics for transaction spans. (Future releases may add support for other trace types than transactions as well.)

Fixes Issue 493.

@nr-swilloughby nr-swilloughby added this to Awaiting User Input in Go Engineering Board via automation Jul 26, 2022
@nr-swilloughby nr-swilloughby self-assigned this Jul 26, 2022
@nr-swilloughby nr-swilloughby moved this from Awaiting User Input to Code Review in Go Engineering Board Jul 26, 2022
@iamemilio
Copy link
Contributor

LGTM

@nr-swilloughby nr-swilloughby marked this pull request as ready for review July 28, 2022 18:15
@nr-swilloughby nr-swilloughby merged commit bbde81d into newrelic:develop Jul 28, 2022
Go Engineering Board automation moved this from Code Review to Done Jul 28, 2022
@nr-swilloughby nr-swilloughby deleted the clm branch July 28, 2022 18:29
@josephnaberhaus-wk
Copy link

@nr-swilloughby this was a major change. It breaks interface compatibility.

*Application used to fulfill this interface:

type example interface {
	StartTransaction(string) *newrelic.Transaction
}

but now it doesn't.

This caused some of our code to stop building once we upgraded to 3.18.0. We have fixed this issue on our end, but I wanted to give you a heads up.

@nr-swilloughby
Copy link
Contributor Author

@josephnaberhaus-wk Thank you for the heads up. We'll push out a fix for this ASAP, most likely early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants