New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeStream Integration Code-Level Metrics for Transactions #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-swilloughby
added this to Awaiting User Input
in Go Engineering Board
via automation
Jul 26, 2022
nr-swilloughby
moved this from Awaiting User Input
to Code Review
in Go Engineering Board
Jul 26, 2022
LGTM |
iamemilio
approved these changes
Jul 28, 2022
@nr-swilloughby this was a major change. It breaks interface compatibility.
type example interface {
StartTransaction(string) *newrelic.Transaction
} but now it doesn't. This caused some of our code to stop building once we upgraded to 3.18.0. We have fixed this issue on our end, but I wanted to give you a heads up. |
@josephnaberhaus-wk Thank you for the heads up. We'll push out a fix for this ASAP, most likely early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code-level metrics for transaction spans. (Future releases may add support for other trace types than transactions as well.)
Fixes Issue 493.