Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvest Limit Increase + Patch for DT Spans #540

Merged
merged 7 commits into from Aug 1, 2022
Merged

Harvest Limit Increase + Patch for DT Spans #540

merged 7 commits into from Aug 1, 2022

Conversation

mirackara
Copy link
Contributor

@mirackara mirackara commented Jul 25, 2022 •
edited

Harvest Limit Increase

  • Changed static values in TestCopyConfigReferenceFieldsAbsent and TestDefaultEventHarvestConfigJSON to dynamically check Custom Event Limits

DT Spans Patch

  • Fixed an issue where DT Spans were not being set to the correct value

@iamemilio iamemilio marked this pull request as ready for review July 26, 2022 17:52
iamemilio
iamemilio previously approved these changes Jul 26, 2022
View reviewed changes
@iamemilio iamemilio self-requested a review July 26, 2022 17:53
iamemilio
iamemilio reviewed Jul 26, 2022
View reviewed changes
v3/internal/limits.go Outdated Show resolved Hide resolved
@iamemilio iamemilio self-requested a review July 26, 2022 17:54
iamemilio
iamemilio reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@iamemilio iamemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a question about where we stand with harvest limits currently

@nr-swilloughby nr-swilloughby merged commit eaaf111 into newrelic:develop Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamemilio iamemilio iamemilio approved these changes

@nr-swilloughby nr-swilloughby Awaiting requested review from nr-swilloughby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mirackara @iamemilio @nr-swilloughby