Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Grpc* transaction attribute names to conform to standard convention #492

Closed
nr-swilloughby opened this issue May 13, 2022 · 0 comments · Fixed by #523, #531 or newrelic/docs-website#8258
Closed

Rename Grpc* transaction attribute names to conform to standard convention #492

nr-swilloughby opened this issue May 13, 2022 · 0 comments · Fixed by #523, #531 or newrelic/docs-website#8258
Assignees
@mirackara
Labels
bug good first issue
Projects
Go Engineering Board

Comments

@nr-swilloughby
Copy link
Contributor

Description

The gRPC attributes added in the error-handling portion of the nrgrpc integration start with upper-case letters:
GrpcStatusLevel
GrpcStatusMessage
GrpcStatusCode

to be consistent with established conventions for agent attributes, they should start with lower-case letters:
grpcStatusLevel
grpcStatusMessage
grpcStatusCode
@nr-swilloughby nr-swilloughby added this to Awaiting User Input in Go Engineering Board via automation May 13, 2022
@nr-swilloughby nr-swilloughby self-assigned this May 13, 2022
@nr-swilloughby nr-swilloughby moved this from Awaiting User Input to Triage in Go Engineering Board May 13, 2022
@Ak-x Ak-x assigned mirackara and unassigned nr-swilloughby Jun 27, 2022
@Ak-x Ak-x moved this from Triage to To Do in Go Engineering Board Jun 27, 2022
@mirackara mirackara moved this from To Do to Code Review in Go Engineering Board Jun 27, 2022
@mirackara mirackara linked a pull request Jun 27, 2022 that will close this issue
gRPC attributes rename #523
Merged
This was referenced Jun 29, 2022
Merged
Merged
Go Engineering Board automation moved this from Code Review to Done Jun 29, 2022
@nr-swilloughby nr-swilloughby mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirackara mirackara

Labels
bug good first issue
Projects
Go Engineering Board
Done
Milestone
No milestone
2 participants
@mirackara @nr-swilloughby