Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can not configure max samples stored for custom events #476

Closed
iamemilio opened this issue Apr 4, 2022 · 1 comment · Fixed by #524 or newrelic/docs-website#8258
Closed

can not configure max samples stored for custom events #476

iamemilio opened this issue Apr 4, 2022 · 1 comment · Fixed by #524 or newrelic/docs-website#8258
Assignees
@mirackara
Labels
bug Quality & UX Code Quality and User Experience
Projects
Go Engineering Board

Comments

@iamemilio
Copy link
Contributor

Description

It is a standard protocol for other agents to allow users to configure the number of custom events stored with a configuration setting named: "custom_insights_events.max_samples_stored": 1000,. This option is not available in the Go agent config.
@iamemilio iamemilio added the bug label Apr 4, 2022
@iamemilio iamemilio added this to Triage in Go Engineering Board Apr 4, 2022
Go Engineering Board automation moved this from Triage to Done Apr 15, 2022
Go Engineering Board automation moved this from Done to Awaiting User Input Apr 15, 2022
@nr-swilloughby nr-swilloughby moved this from Awaiting User Input to Triage in Go Engineering Board Apr 15, 2022
@Ak-x Ak-x moved this from Triage to To Do in Go Engineering Board Apr 19, 2022
@iamemilio iamemilio added the Quality & UX Code Quality and User Experience label May 23, 2022
@mirackara mirackara self-assigned this Jun 21, 2022
@mirackara mirackara moved this from To Do to In progress in Go Engineering Board Jun 27, 2022
@mirackara mirackara linked a pull request Jun 27, 2022 that will close this issue
Custom Events Limiter #524
Merged
@mirackara mirackara moved this from In progress to Code Review in Go Engineering Board Jun 27, 2022
@nr-swilloughby nr-swilloughby mentioned this issue Jun 29, 2022
Merged
@mirackara
Copy link
Contributor

Closing Issue per https://github.com/newrelic/go-agent/wiki/Release-Checklist

Go Engineering Board automation moved this from Code Review to Done Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirackara mirackara

Labels
bug Quality & UX Code Quality and User Experience
Projects
Go Engineering Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom Events Limiter mirackara/go-agent
go agent release v3.17.0 nr-swilloughby/docs-website
3 participants
@iamemilio @mirackara @nr-swilloughby