need dependency on axios

[xenoterracide]

with yarn 2 PnP, modules cant require/import other modules unless they are a dependency, so it won't pick up axios just because I imported it.

1 import { AxiosRequestConfig, AxiosResponse } from 'axios';

maybe worth saying on version 0.20 I have this issue axios/axios#3219

[azakordonets]

@xenoterracide sorry not sure i'm following you - do you suggest to add axios to dependencies of this library, or to upgrade axios library to 0.21 version ?

[xenoterracide]

yes, both. or maybe downgrade it to 0.19.2, I notice a lot of other libraries using 0.19...

[azakordonets]

@xenoterracide fixed in v.0.1..6 . Let me know if it's still a problem.

[xenoterracide]

hmm... I'm not able to reproduce it, but then I'm not working on that branch... and I lamely didn't post enough about what I was doing. however it looks like you have that dependency in devDependencies when it should be in dependencies also, I'm ok with a dependency on ^0.19.2 I just wanted to be able to do earlier than 0.20

[azakordonets]

@xenoterracide added deps in 0.1.7. Let me know if it's ok to close this ticket

[xenoterracide]

better, but you still might want to make the dep *^*0.19.2 so if someone wants to use 0.21.x they can without ending up with a second version. I'll leave that up to you, but otherwise looks fine.

[azakordonets]

You're right, i missed it. Corrected in v0.1.8. Thanks!

[xenoterracide]

looks good, thanks for the work