From 86b4012b92362ecf9514fcbc642c539f8f8c5282 Mon Sep 17 00:00:00 2001 From: David Alberto Adler Date: Mon, 17 Jan 2022 04:08:06 -0800 Subject: [PATCH] Respect `mangle: false` & `sourceMap: false` in `minifierConfig` (#749) Summary: Fixes https://github.com/facebook/metro/issues/301 Pull Request resolved: https://github.com/facebook/metro/pull/749 Reviewed By: motiz88 Differential Revision: D33398597 Pulled By: rh389 fbshipit-source-id: c6fff45e20df500977215bebe6707d0bb84e84d2 --- packages/metro-minify-terser/src/minifier.js | 21 ++++++++++++------- packages/metro-minify-uglify/src/minifier.js | 22 +++++++++++++------- 2 files changed, 27 insertions(+), 16 deletions(-) diff --git a/packages/metro-minify-terser/src/minifier.js b/packages/metro-minify-terser/src/minifier.js index 025e8b0386..8b9c27fee6 100644 --- a/packages/metro-minify-terser/src/minifier.js +++ b/packages/metro-minify-terser/src/minifier.js @@ -33,15 +33,20 @@ function minify({code, map, reserved, config}: MinifierOptions): { } { const options = { ...config, - mangle: { - ...config.mangle, - reserved, - }, + mangle: + config.mangle === false + ? false + : { + ...config.mangle, + reserved, + }, sourceMap: map - ? { - ...config.sourceMap, - content: map, - } + ? config.sourceMap === false + ? false + : { + ...config.sourceMap, + content: map, + } : false, }; diff --git a/packages/metro-minify-uglify/src/minifier.js b/packages/metro-minify-uglify/src/minifier.js index 5578d1224c..9ba64514cd 100644 --- a/packages/metro-minify-uglify/src/minifier.js +++ b/packages/metro-minify-uglify/src/minifier.js @@ -34,14 +34,20 @@ function minify({code, map, reserved, config}: MinifierOptions): { } { const options = { ...config, - mangle: { - ...config.mangle, - reserved, - }, - sourceMap: { - ...config.sourceMap, - content: map, - }, + mangle: + config.mangle === false + ? false + : { + ...config.mangle, + reserved, + }, + sourceMap: + config.sourceMap === false + ? false + : { + ...config.sourceMap, + content: map, + }, }; /* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment suppresses an