Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessagePackSecurity.GetEqualityComparer<object> returns null on copied instances #810

Closed
AArnott opened this issue Feb 7, 2020 · 0 comments · Fixed by #811
Closed

MessagePackSecurity.GetEqualityComparer<object> returns null on copied instances #810

AArnott opened this issue Feb 7, 2020 · 0 comments · Fixed by #811
Assignees
@AArnott
Labels
bug
Milestone
v2.1

Comments

@AArnott
Copy link
Collaborator

AArnott commented Feb 7, 2020

When a MessagePackSecurity instance is mutated, the copy constructor doesn't initialize its objectFallbackEqualityComparer field, leading to future calls to MessagePackSecurity.GetEqualityComparer<object> to return null.

What's particularly hazardous about this is that null is interpreted by Dictionary<K,V> to mean "default comparer" so it defeats the hash collision resistant fixes we made recently.
@AArnott AArnott added the bug label Feb 7, 2020
@AArnott AArnott added this to the v2.1 milestone Feb 7, 2020
@AArnott AArnott self-assigned this Feb 7, 2020
AArnott added a commit to AArnott/MessagePack-CSharp that referenced this issue Feb 7, 2020
@AArnott
Fix MessagePackSecurity.GetEqualityComparer<object> to not return null
e08c4c1 
Fixes MessagePack-CSharp#810
@AArnott AArnott mentioned this issue Feb 7, 2020
Merged
AArnott added a commit to AArnott/MessagePack-CSharp that referenced this issue Feb 7, 2020
@AArnott
Fix MessagePackSecurity.GetEqualityComparer<object> to not return null
a1fb68b 
Fixes MessagePack-CSharp#810
@AArnott AArnott mentioned this issue Feb 7, 2020
Merged
@dependabot dependabot bot mentioned this issue Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
bug
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

Fix MessagePackSecurity.GetEqualityComparer<object> to not return null AArnott/MessagePack-CSharp
1 participant
@AArnott