Stop building assembly version with revision precision #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came from the master branch, which is unstable so revision-level precision is useful. But in a stable v1.8 branch we really want major.minor precision only. Doing so now makes the assembly version go *backwards* from 1.8.74.32478 (the last released package) to 1.8.0.0. This is odd, but at this point we only have a small handful of downloads of the 1.8.74 package, so best to fix it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came from the master branch, which is unstable so revision-level precision is useful.
But in a stable v1.8 branch we really want major.minor precision only.
Doing so now makes the assembly version go backwards from 1.8.74.32478 (the last released package) to 1.8.0.0.
This is odd, but at this point we only have a small handful of downloads of the 1.8.74 package, so best to fix it now.