Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry/expire: Should not use tokens expiration time #1612

Open
denis-tingaikin opened this issue Apr 16, 2024 · 0 comments
Open

registry/expire: Should not use tokens expiration time #1612

denis-tingaikin opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Apr 16, 2024

Expected Behavior

registry/expire: Should not look at the token expiration time

Current Behavior

registry/expire: Should looks at the token expiration time on selecting expiration time for the endpoint.

Failure Information (for bugs)

Steps to Reproduce

  1. Create a registry/expire chain element.
  2. Do a request with a chain of tokens (t1, t2, t3, t4).
  3. Set the path index on 3.
  4. Make the t1 token expiration time lower in the chain.

Actual: expire will use the t4 token expiration time when t1 is lower.
Expected: expire should not look at tokens expiration time. The logic should be moved to the registry/refresh client.

Context

https://github.com/networkservicemesh/sdk/tree/main/pkg/registry/common/expire

@denis-tingaikin denis-tingaikin added the bug Something isn't working label Apr 16, 2024
@denis-tingaikin denis-tingaikin self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Blocked
Development

No branches or pull requests

1 participant