opa: token_expired policy should check only the right side of Path #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=======================================
Coverage ? 70.15%
=======================================
Files ? 248
Lines ? 11203
Branches ? 0
=======================================
Hits ? 7860
Misses ? 2843
Partials ? 500 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I see the problem that we're trying to fix with this patch, but I'm not sure that it will work in all cases. For example, the right part could also be expired, or we may have a custom policy from the user.
It seems to me that closings from timeout should always be authorized.
Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
Closes: #1512
How Has This Been Tested?
Types of changes