Allow using grpc dns target for interdomain scenarious #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
=======================================
Coverage ? 67.09%
=======================================
Files ? 261
Lines ? 12347
Branches ? 0
=======================================
Hits ? 8284
Misses ? 3535
Partials ? 528 ☔ View full report in Codecov by Sentry. |
denis-tingaikin
force-pushed
the
use-dns-target
branch
3 times, most recently
from
3b20292
to
c932ea9
Compare
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
use-dns-target
branch
from
c932ea9
to
3c5143f
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
requested review from
glazychev-art,
NikitaSkrynnik,
edwarnicke,
LionelJouin and
ljkiraly
9 tasks
| require.Equal(t, name+"@"+domains[2].Name, list[0].Name) | ||
| } | ||
|
|
||
| func TestXX(t *testing.T) { |
There was a problem hiding this comment.
I think we should add some require in this test
| if b.domain.Registry != nil { | ||
| require.NoError(b.t, AddSRVEntry(b.dnsResolver, b.name, dnsresolve.DefaultRegistryService, CloneURL(b.domain.Registry.URL))) | ||
| func (b *Builder) addDNSRecords() { | ||
| if b.domain.DNSServer == nil { |
There was a problem hiding this comment.
Maybe add some warnings here? If DNSServer is not set
denis-tingaikin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
Closes #1507
Closes networkservicemesh/deployments-k8s#5435
Closes networkservicemesh/cmd-registry-proxy#1
Closes networkservicemesh/cmd-registry-proxy#2
Closes networkservicemesh/deployments-k8s#9318
Closes networkservicemesh/deployments-k8s#8343
How Has This Been Tested?
Types of changes