Use full schema path to look up type validators for anyOf operator
#663
+283
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prashanthjos, Could you please review the changes to ensure they won't impact your application? Thanks. |
|
@pshevche Thanks a lot for your help. |
My pleasure :) |
pshevche
deleted the
pshevche/662/misleading-error-allOf-invalid-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#626 changed how the schema path is set for
JsonSchemas ofanyOfdeclaration. However, it did not account for the fact that this schema path is used to identify type validators that belong to the operator.AnyOfValidator#validatestill relied on the previous schema path and could not apply special handling to those validators (i.e. execute just the validator that matches the value). As a result,TypeValidators for all options ofanyOfproperty were evaluated separately and results aggregated.Note: I have no clue why the diff for
AnyOfValidatoris so ugly. The screenshot shows what exactly changed:Resolves #662