Correcting the oneOf,anyOf and allOf child schema validators to use the full schema path #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanthjos
changed the title
|
@stevehu can you please have a look at this PR? TIA. |
stevehu
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stevehu can you please have a look at this PR, I wasn't sure why we suppressed the schema path's of child schema under oneOf, anyOf, and allOf to use just the name of the respective keyword and ignore the parent path where these keywords exist. We have use cases where we update the schemas dynamically based on the complete schema path to a node.
I have corrected these classes, can you please have a look and let me know your opinion?
If you feel the PR looks good can you please merge it to the master and release a new version?
Thank you