Use delegate docker mount option to speedup builds #9441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomerd can we upgrade our docker version ? |
Motivation: As we use the docker files for the CI we should use the delegated mount option to speed up builds. See https://docs.docker.com/docker-for-mac/osxfs-caching/#delegated Modifications: Use delegated mount option Result: Faster builds when using docker
normanmaurer
force-pushed
the
docker_delegate
branch
from
718728f
to
eef1a86
Compare
|
@tomerd nevermind had a typo 🤦♂ |
njhill
approved these changes
Aug 12, 2019
normanmaurer
added a commit
that referenced
this pull request
Aug 13, 2019
Motivation: As we use the docker files for the CI we should use the delegated mount option to speed up builds. See https://docs.docker.com/docker-for-mac/osxfs-caching/#delegated Modifications: Use delegated mount option Result: Faster builds when using docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As we use the docker files for the CI we should use the delegate mount option to speed up builds.
See https://docs.docker.com/docker-for-mac/osxfs-caching/#delegated
Modifications:
Use delegate mount option
Result:
Faster builds when using docker