Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the ORIGIN header from a custom headers if present #9435

Merged

Conversation

amizurov
Copy link
Sponsor Contributor

@amizurov amizurov commented Aug 7, 2019

Motivation:

Allow to set the ORIGIN header value from custom headers in WebSocketClientHandshaker

@netty-bot
Copy link

Can one of the admins verify this patch?

@normanmaurer
Copy link
Member

@netty-bot test this please

@normanmaurer normanmaurer added this to the 4.1.39.Final milestone Aug 11, 2019
@normanmaurer normanmaurer merged commit b8ac02d into netty:4.1 Aug 11, 2019
normanmaurer pushed a commit that referenced this pull request Aug 11, 2019
Motivation:

Allow to set the ORIGIN header value from custom headers in WebSocketClientHandshaker

Modification:

Only override header if not present already

Result:

More flexible handshaker usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants