Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StompSubframeDecoder head value contains char ":" parser error #13961

Open
llm163520 opened this issue Apr 9, 2024 · 3 comments
Open

StompSubframeDecoder head value contains char ":" parser error #13961

llm163520 opened this issue Apr 9, 2024 · 3 comments

Comments

@llm163520
Copy link

Expected behavior

image

Actual behavior

Steps to reproduce

Minimal yet complete reproducer code (or URL to code)

html

<script src="sockjs.min.js"></script>
<script src="stomp.min.js"></script> 
<script type="text/javascript">
    var stompClient = Stomp.client("ws://127.0.0.1:8083");
    stompClient.connect({"test": "www.baidu.com?test=321"}, function(frame) {
        console.log('Connected:' + frame);
    }, function(error){
        console.error(error);
    });
</script>

Netty version

4.1.108

JVM version (e.g. java -version)

1.8

OS version (e.g. uname -a)

w10

@llm163520
Copy link
Author

llm163520 commented Apr 9, 2024

Whether it is more reasonable to allow escape

private static boolean shouldUnescape(StompCommand command) {
  return true;
   //return command != StompCommand.CONNECT && command != StompCommand.CONNECTED;
}

@llm163520
Copy link
Author

Or simply let go allow to add to head
image

@normanmaurer
Copy link
Member

We love PRs... That said please also link the relevant RFC section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants