Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory footprint of Recyclers #13945

Open
franz1981 opened this issue Apr 2, 2024 · 2 comments
Open

Reduce memory footprint of Recyclers #13945

franz1981 opened this issue Apr 2, 2024 · 2 comments
Assignees

Comments

@franz1981
Copy link
Contributor

franz1981 commented Apr 2, 2024

Currently Recycler(s) uses mpsc queues from JCTools, which:

  • could not be used at all and just relies on the local array queue (it is what happen if the chunk size capacity is good enough - which is 32 by default (see
    pooledHandles = (MessagePassingQueue<DefaultHandle<T>>) newMpscQueue(chunkSize, maxCapacity);
    )
  • being allocated using padded variant of JCTools

I believe things could be improved by both making the allocations of such queues lazy AND using atomic unpadded or unpadded unsafe variant, while allocated.

We just need a new release of JCTools (from the dear @nitsanw) in order to have both the unpadded flavours in (if unsafe isn't present).

@nitsanw
Copy link
Contributor

nitsanw commented Apr 4, 2024

Will get to it next week

@franz1981
Copy link
Contributor Author

franz1981 commented Apr 4, 2024

If I can help and learn how to roll the release I will, Nitsan, just ping me on Gmail/github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants