WebSocketClientHandshaker: add public accessors for parameters #13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Websocket client & server handshakers may be extended with custom frame encoder / decoder, however client handshaker parameters are private so cant be accessed by custom frame encoder / decoder. Modifications: WebSocketClientHandshaker: add public accessors for parameters. Result: Custom frame encoder / decoder may be provided with websocket client handshaker parameters
normanmaurer
pushed a commit
that referenced
this pull request
Nov 21, 2022
Motivation: Websocket client & server handshakers may be extended with custom frame encoder / decoder, however client handshaker parameters are private so cant be accessed by custom frame encoder / decoder. Modifications: WebSocketClientHandshaker: add public accessors for parameters. Result: Custom frame encoder / decoder may be provided with websocket client handshaker parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
WebSocket client & server handshakers may be extended with custom frame encoder / decoder, however client handshaker parameters are private so cant be passed to custom frame encoder / decoder.
Modifications:
WebSocketClientHandshaker13: add public accessors for parameters.
Result:
Custom frame encoder / decoder may be provided with WebSocket client handshaker parameters.