Avoid failing HTTP/2 requests with upgrade-insecure-requests
#12799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This is a non-standard header that is not _explicitly_ called out as connection related, even though it can be argued that it is. Regardless, Chrome and Firefox do actually send this header in their HTTP/2 requests, so rejecting these is quite troublesome. Safari doesn't send this header. Modification: Remove the check for `upgrade-insecure-requests` in the header validation in HpackDecoder. Also update tests to match. Result: HTTP/2 requests from Chrome and Firefox are no longer rejected by the header validation. Fixes netty#12798
|
@chrisvest can you port this to main as well |
chrisvest
added a commit
that referenced
this pull request
Sep 13, 2022
Motivation: This is a non-standard header that is not _explicitly_ called out as connection related, even though it can be argued that it is. Regardless, Chrome and Firefox do actually send this header in their HTTP/2 requests, so rejecting these is quite troublesome. Safari doesn't send this header. Modification: Remove the check for `upgrade-insecure-requests` in the header validation in HpackDecoder. Also update tests to match. Result: HTTP/2 requests from Chrome and Firefox are no longer rejected by the header validation. Fixes #12798
|
Ported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This is a non-standard header that is not explicitly called out as connection related, even though it can be argued that it is. Regardless, Chrome and Firefox do actually send this header in their HTTP/2 requests, so rejecting these is quite troublesome. Safari doesn't send this header.
Modification:
Remove the check for
upgrade-insecure-requestsin the header validation in HpackDecoder. Also update tests to match.Result:
HTTP/2 requests from Chrome and Firefox are no longer rejected by the header validation.
Fixes #12798