Respect jdk.tls.client.protocols and jdk.tls.server.protocols #12797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We should respect jdk.tls.client.protocols and jdk.tls.server.protocols system property to allow easily to enable / disable protocols Modifications: Respect the system properties Result: Be able to easily enable / disable TLS protocols in a consistent way
chrisvest
approved these changes
Sep 12, 2022
hyperxpro
reviewed
Sep 13, 2022
| Set<String> protocols = new HashSet<String>(); | ||
| for (String proto : protocolsString.split(",")) { | ||
| String p = proto.trim(); | ||
| if (OpenSsl.SUPPORTED_PROTOCOLS_SET.contains(p)) { |
There was a problem hiding this comment.
We should log this when the protocol is defined in the jdk.tls.server.protocols but not supported by OpenSSL.
There was a problem hiding this comment.
The JDK is not logging as well... So I think we should also not do it.
chrisvest
approved these changes
Sep 13, 2022
chrisvest
pushed a commit
that referenced
this pull request
Sep 13, 2022
Motivation: We should respect jdk.tls.client.protocols and jdk.tls.server.protocols system property to allow easily to enable / disable protocols Modifications: Respect the system properties Result: Be able to easily enable / disable TLS protocols in a consistent way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should respect jdk.tls.client.protocols and jdk.tls.server.protocols system property to allow easily to enable / disable protocols
Modifications:
Respect the system properties
Result:
Be able to easily enable / disable TLS protocols in a consistent way