Fix inconsistent synchronization of PoolSubpage.doNotDestroy #12775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This field is modified under lock, and thus should not be accessed (toString excepted) without locking. Modification: Move an assert check on PoolSubpage.doNotDestroy into a nearby critical region. Also encapsulate the findSubpagePoolHead logic better; PoolArena now always use this method instead of that one place that was accessing the array directly. This should not have any influence on the logic. Result: Assert in PoolChunk is no longer racy.
chrisvest
added a commit
that referenced
this pull request
Sep 7, 2022
Motivation: This field is modified under lock, and thus should not be accessed (toString excepted) without locking. Modification: Move an assert check on PoolSubpage.doNotDestroy into a nearby critical region. Also encapsulate the findSubpagePoolHead logic better; PoolArena now always use this method instead of that one place that was accessing the array directly. This should not have any influence on the logic. Result: Assert in PoolChunk is no longer racy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This field is modified under lock, and thus should not be accessed (toString excepted) without locking.
Modification:
Move an assert check on PoolSubpage.doNotDestroy into a nearby critical region.
Also encapsulate the findSubpagePoolHead logic better; PoolArena now always use this method instead of that one place that was accessing the array directly. This should not have any influence on the logic.
Result:
Assert in PoolChunk is no longer racy.