Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicate code in netty-example module. #12733

Merged
merged 1 commit into from Sep 7, 2022
Merged

fix duplicate code in netty-example module. #12733

merged 1 commit into from Sep 7, 2022

Conversation

yoa1226
Copy link
Contributor

@yoa1226 yoa1226 commented Aug 24, 2022

Motivation:

I found some duplicated code when reading the netty code.

Modification:

all the changes in the netty-example module.

Result:

fix duplicate code in netty-example module.

@yoa1226 yoa1226 force-pushed the duplicate_code_in_example_module branch from 39ac079 to efdf05b Compare August 24, 2022 09:25
@yoa1226 yoa1226 force-pushed the duplicate_code_in_example_module branch from efdf05b to c2f30a3 Compare August 24, 2022 11:51
@yoa1226 yoa1226 force-pushed the duplicate_code_in_example_module branch from c2f30a3 to 3e48f0e Compare August 25, 2022 12:12
@yoa1226
Copy link
Contributor Author

yoa1226 commented Aug 25, 2022

@normanmaurer
Hi, i have changed my code. You can review my code when you are free. Thank you !

@yoa1226 yoa1226 force-pushed the duplicate_code_in_example_module branch 3 times, most recently from a0b4aa8 to ff3cc6f Compare August 26, 2022 01:39
@yoa1226 yoa1226 requested review from normanmaurer and removed request for normanmaurer August 28, 2022 09:16
@yoa1226
Copy link
Contributor Author

yoa1226 commented Aug 31, 2022

@normanmaurer
Hi, i have changed my code. You can review my code when you are free. Thank you !

@normanmaurer
Copy link
Member

@coding2world can you please sign our icla and let me know once done: https://netty.io/s/icla ?

@yoa1226
Copy link
Contributor Author

yoa1226 commented Sep 2, 2022

coding2world

@yoa1226 yoa1226 closed this Sep 2, 2022
@yoa1226 yoa1226 reopened this Sep 2, 2022
@yoa1226
Copy link
Contributor Author

yoa1226 commented Sep 2, 2022 •
edited

@coding2world can you please sign our icla and let me know once done: https://netty.io/s/icla ?

@normanmaurer Hi, I have signed your icla.

@yoa1226
Copy link
Contributor Author

yoa1226 commented Sep 6, 2022

@normanmaurer Hi, I have signed your icla. please check this pr when you are free.

@chrisvest
Copy link
Contributor

@coding2world There's a really weird build error. Can you try doing a rebase on the latest 4.1 branch and see if that helps?

@yoa1226
Copy link
Contributor Author

yoa1226 commented Sep 7, 2022

@coding2world There's a really weird build error. Can you try doing a rebase on the latest 4.1 branch and see if that helps?

👌

@yoa1226 yoa1226 force-pushed the duplicate_code_in_example_module branch from ff3cc6f to 7499187 Compare September 7, 2022 04:57
@yoa1226 yoa1226 force-pushed the duplicate_code_in_example_module branch from 7499187 to ab93483 Compare September 7, 2022 05:18
@yoa1226
Copy link
Contributor Author

yoa1226 commented Sep 7, 2022

@chrisvest Hi, I have rebase the code. Could you help me approval the workflow.

@chrisvest chrisvest merged commit d221550 into netty:4.1 Sep 7, 2022
@chrisvest
Copy link
Contributor

@coding2world Thanks!

chrisvest pushed a commit that referenced this pull request Sep 7, 2022
@yoa1226 @chrisvest
fix duplicate code in exampple module. (#12733)
fe8c26d 
Motivation:

I found some duplicated code  when reading the netty code.

Modification:

all the changes in the  netty-example module.

Result:

fix duplicate code in netty-example module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvest chrisvest chrisvest approved these changes

@normanmaurer normanmaurer Awaiting requested review from normanmaurer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yoa1226 @normanmaurer @chrisvest