Skip api compatibility validations for the microbench module #12718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecific configuration from the revapi plugin.
chrisvest
approved these changes
Aug 18, 2022
chrisvest
pushed a commit
that referenced
this pull request
Aug 18, 2022
Motivation: We should be able to evolve and change our benchmark code and infrastructure without worrying about compatibility. Modification: Skip revapi check for the microbench module and remove benchmarking specific configuration from the revapi plugin. Result: The microbench module is no longer subject to compatibility checks. Co-authored-by: ahadadi <ahadadi@outbrain.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip revapi check for the microbench module and remove benchmarking specific configuration from the revapi plugin.
Fixes #12716.