Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable test if brotli is there #12592

Merged
merged 1 commit into from Jul 11, 2022
Merged

Only enable test if brotli is there #12592

merged 1 commit into from Jul 11, 2022

Conversation

normanmaurer
Copy link
Member

Motiviation:

We should only try to run the test if Brotli is really supported on the platform (which is not the case on m1)

Modifications:

Only run if brotli is supported

Result:

Testsuite pass on m1

Motiviation:

We should only try to run the test if Brotli is really supported on the platform (which is not the case on m1)

Modifications:

Only run if brotli is supported

Result:

Testsuite pass on m1
@normanmaurer normanmaurer added this to the 5.0.0.Alpha4 milestone Jul 11, 2022
Copy link
Contributor

@hyperxpro hyperxpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M1 will be supported soon as AWS brought M1 Mac Instances. Just waiting for trial credits.

@normanmaurer normanmaurer merged commit 367697d into main Jul 11, 2022
@normanmaurer normanmaurer deleted the no_brotli branch July 11, 2022 08:26
normanmaurer added a commit that referenced this pull request Jul 11, 2022
Motiviation:

We should only try to run the test if Brotli is really supported on the platform (which is not the case on m1)

Modifications:

Only run if brotli is supported

Result:

Testsuite pass on m1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants