Remove static field from c code base #11894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvest
approved these changes
Dec 6, 2021
transport-native-unix-common/src/main/java/io/netty/channel/unix/Socket.java
Outdated
Show resolved
Hide resolved
Motivation: This came up in another PR. We dont need to store the field in the jni layer which makes things easier. Modifications: Refactor code to just store it in the java class Result: Cleanup
normanmaurer
force-pushed
the
remove_state
branch
from
3fd8e2b
to
5c0e4c4
Compare
chrisvest
approved these changes
Dec 6, 2021
normanmaurer
added a commit
that referenced
this pull request
Dec 6, 2021
Motivation: This came up in another PR. We dont need to store the field in the jni layer which makes things easier. Modifications: Refactor code to just store it in the java class Result: Cleanup
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: This came up in another PR. We dont need to store the field in the jni layer which makes things easier. Modifications: Refactor code to just store it in the java class Result: Cleanup
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: This came up in another PR. We dont need to store the field in the jni layer which makes things easier. Modifications: Refactor code to just store it in the java class Result: Cleanup
10brothers
pushed a commit
to 10brothers/netty
that referenced
this pull request
Jan 20, 2022
Motivation: This came up in another PR. We dont need to store the field in the jni layer which makes things easier. Modifications: Refactor code to just store it in the java class Result: Cleanup
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: This came up in another PR. We dont need to store the field in the jni layer which makes things easier. Modifications: Refactor code to just store it in the java class Result: Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This came up in another PR. We dont need to store the field in the jni layer which makes things easier.
Modifications:
Refactor code to just store it in the java class
Result:
Cleanup