Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "CipherSuitesConverter" to make it public. #11656

Merged

Conversation

kushalagrawal
Copy link
Contributor

@kushalagrawal kushalagrawal commented Sep 4, 2021

Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes #11655

Copy link
Contributor

@hyperxpro hyperxpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyperxpro
Copy link
Contributor

@kushalagrawal I think you might wanna remove the issue template from the description.

@kushalagrawal
Copy link
Contributor Author

@hyperxpro build due to docker image issue. Is there any way to retrigger this build?

---> Running in ead5b2c5b4fe
Loaded plugins: fastestmirror, ovl
Setting up Install Process
https://vault.centos.org/6.10/os/x86_64/repodata/repomd.xml: [Errno 14] PYCURL ERROR 7 - "Failed to connect to 2600:1f13:2e7:2901:d2b0:c3b2:9347:934c: Cannot assign requested address"
Trying other mirror.
Error: Cannot retrieve repository metadata (repomd.xml) for repository: base. Please verify its path and try again
The command '/bin/sh -c yum install -y  apr-devel  autoconf  automake  git  glibc-devel  libtool  lksctp-tools  lsb-core  make  openssl-devel  tar  wget' returned a non-zero code: 1
Service 'runtime-setup' failed to build : Build failed

Error: Process completed with exit code 1.

@hyperxpro
Copy link
Contributor

Only Members of Netty can trigger re-build.

@chrisvest Can you?

@kushalagrawal kushalagrawal force-pushed the public_cipher_suites_converter branch 2 times, most recently from 58363ab to e5bf61f Compare September 6, 2021 05:02
Copy link
Member

@normanmaurer normanmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kushalagrawal can you please add the @UnstableApi annotation to the class

@hyperxpro
Copy link
Contributor

Also, I think you mean CipherSuitesConverter, not CipherSuitesConverted.

@kushalagrawal kushalagrawal changed the title Updated "CipherSuitesConverted" to make it public. Updated "CipherSuitesConverter" to make it public. Sep 6, 2021
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
@normanmaurer normanmaurer added this to the 4.1.68.Final milestone Sep 6, 2021
@normanmaurer normanmaurer merged commit a329857 into netty:4.1 Sep 6, 2021
@normanmaurer
Copy link
Member

Thanks a lot !

normanmaurer pushed a commit that referenced this pull request Sep 6, 2021
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes #11655
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this pull request Dec 16, 2021
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this pull request Dec 16, 2021
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
raidyue pushed a commit to raidyue/netty that referenced this pull request Jul 8, 2022
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to CipherSuitesConverter outside of the io.netty.handler.ssl
3 participants