New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated "CipherSuitesConverter" to make it public. #11656
Updated "CipherSuitesConverter" to make it public. #11656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kushalagrawal I think you might wanna remove the issue template from the description. |
@hyperxpro build due to docker image issue. Is there any way to retrigger this build?
|
Only @chrisvest Can you? |
58363ab
to
e5bf61f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushalagrawal can you please add the @UnstableApi
annotation to the class
e5bf61f
to
0293c9f
Compare
Also, I think you mean |
Motivation: While using netty there is sometimes need to handle the cipher suites and signature algorithm in more strict environment. CipherSuiteConverter is quite helpful in converting Cipher-Suites to and from java to openSSL. Making it public would be helpful for the project which are using netty. Modification: Updated "CipherSuitesConverter" to make it public. updated "CipherSuitesConverter.toOpenssl" to public. updated "CipherSuitesConverter.toJava" to public. Result: Fixes netty#11655
0293c9f
to
6207070
Compare
Thanks a lot ! |
Motivation: While using netty there is sometimes need to handle the cipher suites and signature algorithm in more strict environment. CipherSuiteConverter is quite helpful in converting Cipher-Suites to and from java to openSSL. Making it public would be helpful for the project which are using netty. Modification: Updated "CipherSuitesConverter" to make it public. updated "CipherSuitesConverter.toOpenssl" to public. updated "CipherSuitesConverter.toJava" to public. Result: Fixes #11655
Motivation: While using netty there is sometimes need to handle the cipher suites and signature algorithm in more strict environment. CipherSuiteConverter is quite helpful in converting Cipher-Suites to and from java to openSSL. Making it public would be helpful for the project which are using netty. Modification: Updated "CipherSuitesConverter" to make it public. updated "CipherSuitesConverter.toOpenssl" to public. updated "CipherSuitesConverter.toJava" to public. Result: Fixes netty#11655
Motivation: While using netty there is sometimes need to handle the cipher suites and signature algorithm in more strict environment. CipherSuiteConverter is quite helpful in converting Cipher-Suites to and from java to openSSL. Making it public would be helpful for the project which are using netty. Modification: Updated "CipherSuitesConverter" to make it public. updated "CipherSuitesConverter.toOpenssl" to public. updated "CipherSuitesConverter.toJava" to public. Result: Fixes netty#11655
Motivation: While using netty there is sometimes need to handle the cipher suites and signature algorithm in more strict environment. CipherSuiteConverter is quite helpful in converting Cipher-Suites to and from java to openSSL. Making it public would be helpful for the project which are using netty. Modification: Updated "CipherSuitesConverter" to make it public. updated "CipherSuitesConverter.toOpenssl" to public. updated "CipherSuitesConverter.toJava" to public. Result: Fixes netty#11655
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.
Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.
Result:
Fixes #11655