Improve test failure reporting of EpollSocketChannelConfigTest #11570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This test is inherently flaky due to file descriptor reuse. Even though we have taken steps to make it less flaky, it still fails sometimes. When it does, the error message is not very helpful. Modification: Make use of assertThrows and assertThat to get more descriptive error messages when the tests fail. Result: More meaningful messages on test failures, which may help us make the tests more resilient in the future
|
Recently saw this one fail on #11565 despite the repeat annotations. |
NiteshKant
approved these changes
Aug 11, 2021
chrisvest
added a commit
that referenced
this pull request
Aug 12, 2021
Motivation: This test is inherently flaky due to file descriptor reuse. Even though we have taken steps to make it less flaky, it still fails sometimes. When it does, the error message is not very helpful. Modification: Make use of assertThrows and assertThat to get more descriptive error messages when the tests fail. Result: More meaningful messages on test failures, which may help us make the tests more resilient in the future
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
…#11570) Motivation: This test is inherently flaky due to file descriptor reuse. Even though we have taken steps to make it less flaky, it still fails sometimes. When it does, the error message is not very helpful. Modification: Make use of assertThrows and assertThat to get more descriptive error messages when the tests fail. Result: More meaningful messages on test failures, which may help us make the tests more resilient in the future
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
…#11570) Motivation: This test is inherently flaky due to file descriptor reuse. Even though we have taken steps to make it less flaky, it still fails sometimes. When it does, the error message is not very helpful. Modification: Make use of assertThrows and assertThat to get more descriptive error messages when the tests fail. Result: More meaningful messages on test failures, which may help us make the tests more resilient in the future
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…#11570) Motivation: This test is inherently flaky due to file descriptor reuse. Even though we have taken steps to make it less flaky, it still fails sometimes. When it does, the error message is not very helpful. Modification: Make use of assertThrows and assertThat to get more descriptive error messages when the tests fail. Result: More meaningful messages on test failures, which may help us make the tests more resilient in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This test is inherently flaky due to file descriptor reuse.
Even though we have taken steps to make it less flaky, it still fails sometimes.
When it does, the error message is not very helpful.
Modification:
Make use of assertThrows and assertThat to get more descriptive error messages when the tests fail.
Result:
More meaningful messages on test failures, which may help us make the tests more resilient in the future