New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server h2c upgrade fail when request doesn't have connection header #11569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please sign our ICLA and let us know once done. |
finished |
Can you add a test case also? |
chrisvest
approved these changes
Aug 12, 2021
Please update the title also. |
dpy1123
changed the title
Update HttpServerUpgradeHandler.java
server h2c upgrade should fail when request doesn`t have connection header
Aug 12, 2021
dpy1123
changed the title
server h2c upgrade should fail when request doesn`t have connection header
server h2c upgrade should fail when request doesn't have connection header
Aug 12, 2021
dpy1123
changed the title
server h2c upgrade should fail when request doesn't have connection header
server h2c upgrade fail when request doesn't have connection header
Aug 12, 2021
chrisvest
reviewed
Aug 12, 2021
codec-http/src/test/java/io/netty/handler/codec/http/HttpServerUpgradeHandlerTest.java
Show resolved
Hide resolved
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
…etty#11569) __Motivation__ Since request.headers().getAll() will never return null. And the check null condition will not work as expected. __Modification__ Add isEmpty() checking as well. __Result__ Fixes netty#11568
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
…etty#11569) __Motivation__ Since request.headers().getAll() will never return null. And the check null condition will not work as expected. __Modification__ Add isEmpty() checking as well. __Result__ Fixes netty#11568
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…etty#11569) __Motivation__ Since request.headers().getAll() will never return null. And the check null condition will not work as expected. __Modification__ Add isEmpty() checking as well. __Result__ Fixes netty#11568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Since
request.headers().getAll()
will never return null. And the check null condition will not work as expected.Modification:
Add
isEmpty()
checking as well.Result:
Fixes #11568