Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server h2c upgrade fail when request doesn't have connection header #11569

Merged
merged 4 commits into from Aug 12, 2021

Conversation

dpy1123
Copy link
Contributor

@dpy1123 dpy1123 commented Aug 11, 2021

Motivation:
Since request.headers().getAll() will never return null. And the check null condition will not work as expected.

Modification:

Add isEmpty() checking as well.

Result:

Fixes #11568

@hyperxpro
Copy link
Contributor

Please sign our ICLA and let us know once done.

http://netty.io/s/icla

@dpy1123
Copy link
Contributor Author

dpy1123 commented Aug 11, 2021

finished

@hyperxpro
Copy link
Contributor

Can you add a test case also?

@hyperxpro
Copy link
Contributor

Please update the title also.

@dpy1123 dpy1123 changed the title Update HttpServerUpgradeHandler.java server h2c upgrade should fail when request doesn`t have connection header Aug 12, 2021
@dpy1123 dpy1123 changed the title server h2c upgrade should fail when request doesn`t have connection header server h2c upgrade should fail when request doesn't have connection header Aug 12, 2021
@dpy1123 dpy1123 changed the title server h2c upgrade should fail when request doesn't have connection header server h2c upgrade fail when request doesn't have connection header Aug 12, 2021
@NiteshKant NiteshKant added this to the 4.1.67.Final milestone Aug 12, 2021
@NiteshKant NiteshKant merged commit 056eba4 into netty:4.1 Aug 12, 2021
NiteshKant pushed a commit that referenced this pull request Aug 12, 2021
…11569)

__Motivation__
Since request.headers().getAll() will never return null. And the check null condition will not work as expected.

__Modification__

Add isEmpty() checking as well.

__Result__

Fixes #11568
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this pull request Dec 16, 2021
…etty#11569)

__Motivation__
Since request.headers().getAll() will never return null. And the check null condition will not work as expected.

__Modification__

Add isEmpty() checking as well.

__Result__

Fixes netty#11568
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this pull request Dec 16, 2021
…etty#11569)

__Motivation__
Since request.headers().getAll() will never return null. And the check null condition will not work as expected.

__Modification__

Add isEmpty() checking as well.

__Result__

Fixes netty#11568
raidyue pushed a commit to raidyue/netty that referenced this pull request Jul 8, 2022
…etty#11569)

__Motivation__
Since request.headers().getAll() will never return null. And the check null condition will not work as expected.

__Modification__

Add isEmpty() checking as well.

__Result__

Fixes netty#11568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpServerUpgradeHandler causing StringIndexOutOfBoundsException
5 participants