Fix netty-all artifact #11274
Fix netty-all artifact #11274
Conversation
| </dependency> | ||
| </dependencies> | ||
| </profile> | ||
|
|
||
| <profile> | ||
| <id>full</id> |
There was a problem hiding this comment.
This is not needed anymore as we moved the Javadoc etc generated to the parent pom.xml
|
/cc @fredericBregier |
|
@normanmaurer OK, I will wait for a new release to be able to check, I think it shall be ok. Thanks ! |
|
@chrisvest sadly yes :/ |
|
/cc @candrews |
|
Instead of reverting, I feel like fixing the problem would be preferable. I'll take a look - I see others are doing so as well |
|
@candrews generally speaking yes... that said I think we need to release a regression fix release asap. And as it has shown we need to take more time to really ensure that everything works as expected. |
|
I agree with @normanmaurer. Since this turned out to be unexpectedly tricky, and there are other fixes waiting for release, I think it's a better trade-off to do the revert in this PR, regressing the netty-all class path behaviour to the state it's been for years prior, and then there's no time pressure on #11278. |
|
Let's pull this in and then #11278 can revert this change and add its own changes on top of it. |
Motivation: 612ab58 did change the way how netty-all was produced by unfortunally it messed up the dependency graph for our native artifacts. This commit reverts changes done by 612ab58 and also clean up the profiles Modifications: netty-all is useable again Result: Fixes netty#11272
Motivation:
612ab58 did change the way how netty-all was produced by unfortunally it messed up the dependency graph for our native artifacts. This commit reverts changes done by 612ab58 and also clean up the profiles
Modifications:
netty-all is useable again
Result:
Fixes #11272