More strict parsing of initial line / http headers #10058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Our parsing of the initial line / http headers did treat some characters as separators which should better trigger an exception during parsing. Modifications: - Tighten up parsing of the inital line by follow recommentation of RFC7230 - Restrict separators to OWS for http headers - Add unit test Result: Stricter parsing of HTTP1
normanmaurer
requested review from
NiteshKant,
bryce-anderson and
idelpivnitskiy
|
/cc @violetagg |
codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectDecoder.java
Outdated
Show resolved
Hide resolved
bryce-anderson
approved these changes
Feb 25, 2020
normanmaurer
added a commit
that referenced
this pull request
Feb 26, 2020
Motivation: Our parsing of the initial line / http headers did treat some characters as separators which should better trigger an exception during parsing. Modifications: - Tighten up parsing of the inital line by follow recommentation of RFC7230 - Restrict separators to OWS for http headers - Add unit test Result: Stricter parsing of HTTP1
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
Motivation: Our parsing of the initial line / http headers did treat some characters as separators which should better trigger an exception during parsing. Modifications: - Tighten up parsing of the inital line by follow recommentation of RFC7230 - Restrict separators to OWS for http headers - Add unit test Result: Stricter parsing of HTTP1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our parsing of the initial line / http headers did treat some characters as separators which should better trigger an exception during parsing.
Modifications:
Result:
Stricter parsing of HTTP1