Corruption on message writing/reading

[PedroMPagani]

I am using netty to write a message to another Minecraft server but from time to time the data doesnt seem to be getting sent properly

public class EntitySyncMessage extends FalconMessage {

    private Entity entity;
    private CompoundTag compoundTag;

    public void setEntity(Entity entity) {
        this.entity = entity;
    }

    public EntitySyncMessage(){
        super(3);
    }
    @Override
    public void write(FriendlyByteBuf buf) {
        try {
            CompoundTag compoundTag = serialize(entity);
            EntityDataSerializers.COMPOUND_TAG.write(buf, compoundTag);
        } catch (Exception e) {
            e.printStackTrace();
        }
    }


    @Override
    public void read(FriendlyByteBuf buf) {
        try {
            this.compoundTag = buf.readNbt();
        } catch (Exception e) {
            e.printStackTrace();
        }
    }

    public static CompoundTag serialize(Entity entity){
        CompoundTag tag = new CompoundTag();
        String entityTypeKey = EntityType.getKey(entity.getType()).toString();
        tag.putString("entityKey", entityTypeKey);
        entity.saveWithoutId(tag);
        return tag;
    }

    public static Entity deserialize(CompoundTag tag, Level level){
        String entityTypeString = tag.getString("entityKey");
        EntityType<?> entityType = EntityType.byString(entityTypeString).orElse(null);
        if (entityType == null) {
            throw new IllegalArgumentException("Invalid entity type: " + entityTypeString);
        }
        Entity entity = entityType.create(level);
        assert entity != null;
        try {
            entity.load(tag);
        } catch (Exception exception){

        }
        return entity;
    }

    private void sendEntitySpawnPacketToAllPlayers(Entity nmsEntity){
        Packet<?> packet = new ClientboundAddEntityPacket(nmsEntity);

        for (Player player : Bukkit.getOnlinePlayers()){
            ServerPlayer nmsPlayer = ((CraftPlayer) player).getHandle();
            nmsPlayer.connection.send(packet);
        }

    }

    @Override
    public void log(String sg) {
        Bukkit.broadcastMessage(String.valueOf(compoundTag));
    }

    @Override
    public Runnable runnable() {
        return () -> {
            try {
                ServerLevel world = ((CraftWorld) Objects.requireNonNull(Bukkit.getWorld("world"))).getHandle();
                assert world != null;
                Entity nmsEntity = deserialize(compoundTag, world);
                nmsEntity.setFalcon(true);nmsEntity.setId(Entity.nextEntityId());
                float f = (float) Mth.floor((Mth.wrapDegrees(180 - 180.0F) + 22.5F) / 45.0F) * 45.0F;
                nmsEntity.moveTo(nmsEntity.getX(), nmsEntity.getY(), nmsEntity.getZ(), f, 0.0F);
                // CraftBukkit end
                world.addFreshEntityWithPassengers(nmsEntity);
                sendEntitySpawnPacketToAllPlayers(nmsEntity);
            } catch (Exception exception){
                exception.printStackTrace();
            }
        };
    }

}

This is the code I have to send the specific message, my publisher is:

    public void publish(FalconMessage message) {
        executor.execute(() -> {
            try {
                this.channelPool.acquire().addListener((FutureListener<Channel>) channelFuture -> {
                    if (channelFuture.isSuccess()) {
                        Channel channel = channelFuture.getNow();
                        ByteBuf friendlyByteBuf = message.get();
                        ChannelFuture future = channel.writeAndFlush(friendlyByteBuf).sync();
                        future.addListener((ChannelFutureListener) writeFuture -> {
                            if (writeFuture.isSuccess()) {
                                System.out.println(channel.isOpen() + " publish finish");
                            } else {
                                Throwable cause = writeFuture.cause();
                                System.err.println("Failed to send message: " + cause.getMessage());
                                cause.printStackTrace();
                            }
                            this.channelPool.release(channel);
                            ReferenceCountUtil.release(friendlyByteBuf);
                        });
                    } else {
                        Throwable cause = channelFuture.cause();
                        System.err.println("Failed to acquire channel: " + cause.getMessage());
                        cause.printStackTrace();
                    }
                });
            } catch (Exception exception) {
                exception.printStackTrace();
            }
        });
    }

[PedroMPagani]

The exception caught is

[10:32:27 WARN]: net.minecraft.ReportedException: Loading NBT data
[10:32:27 WARN]:        at net.minecraft.nbt.NBTCompressedStreamTools.a(NBTCompressedStreamTools.java:299)
[10:32:27 WARN]:        at net.minecraft.nbt.NBTCompressedStreamTools.a(NBTCompressedStreamTools.java:238)
[10:32:27 WARN]:        at net.minecraft.network.PacketDataSerializer.a(PacketDataSerializer.java:670)
[10:32:27 WARN]:        at net.minecraft.network.PacketDataSerializer.p(PacketDataSerializer.java:651)
[10:32:27 WARN]:        at org.falcon.dao.EntitySyncMessage.read(EntitySyncMessage.java:61)
[10:32:27 WARN]:        at org.falcon.c.MyPublisherHandler.channelRead0(MyPublisherHandler.java:29)
[10:32:27 WARN]:        at org.falcon.c.MyPublisherHandler.channelRead0(MyPublisherHandler.java:12)
[10:32:27 WARN]:        at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)
[10:32:27 WARN]:        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
[10:32:27 WARN]:        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
[10:32:27 WARN]:        at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
[10:32:27 WARN]:        at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
[10:32:27 WARN]:        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440)
[10:32:27 WARN]:        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
[10:32:27 WARN]:        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
[10:32:27 WARN]:        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
[10:32:27 WARN]:        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788)
[10:32:27 WARN]:        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
[10:32:27 WARN]:        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
[10:32:27 WARN]:        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
[10:32:27 WARN]:        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
[10:32:27 WARN]:        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
[10:32:27 WARN]:        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
[10:32:27 WARN]:        at java.base/java.lang.Thread.run(Thread.java:833)
[10:32:27 WARN]: Caused by: java.io.EOFException
[10:32:27 WARN]:        at java.base/java.io.DataInputStream.readFully(DataInputStream.java:203)
[10:32:27 WARN]:        at java.base/java.io.DataInputStream.readUTF(DataInputStream.java:614)
[10:32:27 WARN]:        at java.base/java.io.DataInputStream.readUTF(DataInputStream.java:570)
[10:32:27 WARN]:        at net.minecraft.nbt.CompoundTag.readNamedTagName(CompoundTag.java:508)
[10:32:27 WARN]:        at net.minecraft.nbt.CompoundTag$1.load(CompoundTag.java:44)
[10:32:27 WARN]:        at net.minecraft.nbt.CompoundTag$1.b(CompoundTag.java:33)
[10:32:27 WARN]:        at net.minecraft.nbt.NbtIo.readUnnamedTag(NbtIo.java:293)
[10:32:27 WARN]:        at net.minecraft.nbt.NbtIo.read(NbtIo.java:238)
[10:32:27 WARN]:        at net.minecraft.network.FriendlyByteBuf.readNbt(FriendlyByteBuf.java:670)
[10:32:27 WARN]:        at net.minecraft.network.FriendlyByteBuf.readNbt(FriendlyByteBuf.java:651)
[10:32:27 WARN]:        ... 20 more

But the data is being encoded properly, when I apply manual read with the FriendlyByteBuf it works 100% of the time(on the side that sends the data, with a full byte copy <<), I have debugged this, the EntitySyncMessage also works a lot of times too, but from time to time it fails, with that exception.

I am suspicious that I am handling the ByteBuf in a wrong way, it is the first time I am using netty for this purpose

[PedroMPagani]

This was not packet loss or data loss, it seems that the messages mix up bytes and there's a custom addon to pipelines that fixes this.