Return 0 for SSL_OP_NO_TLSv1_3 when TLSv1.3 is not supported. #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We need to use 0 for SSL_OP_NO_TLSv1_3 when TLSv1.3 is not supported to not disable any protocols by mistake when its not supported at all. Modifications: Define SSL_OP_NO_TLSv1_3 as 0 when TLSv1.3 is not supported. Result: Correctly handle the case when TLSv1.3 is not supported and so be able to use it in this case.
normanmaurer
requested review from
carl-mastrangelo,
ejona86,
Scottmitch and
trustin
|
I messed this one up ... We need this to be able to correctly handle both cases: when TLSv1.3 is supported and if its not supported. |
|
Once this is merged I will cut a release. |
|
@netty-bot test this please |
|
@netty-bot test this please |
fzakaria
pushed a commit
to fzakaria/netty-tcnative
that referenced
this pull request
Feb 4, 2019
) Motivation: We need to use 0 for SSL_OP_NO_TLSv1_3 when TLSv1.3 is not supported to not disable any protocols by mistake when its not supported at all. Modifications: Define SSL_OP_NO_TLSv1_3 as 0 when TLSv1.3 is not supported. Result: Correctly handle the case when TLSv1.3 is not supported and so be able to use it in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to use 0 for SSL_OP_NO_TLSv1_3 when TLSv1.3 is not supported to not disable any protocols by mistake when its not supported at all.
Modifications:
Define SSL_OP_NO_TLSv1_3 as 0 when TLSv1.3 is not supported.
Result:
Correctly handle the case when TLSv1.3 is not supported and so be able to use it in this case.