Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Library Cleaning and Rebuilding #121

Closed
Scottmitch opened this issue Feb 23, 2016 · 9 comments
Closed

Static Library Cleaning and Rebuilding #121

Scottmitch opened this issue Feb 23, 2016 · 9 comments
Assignees
Milestone

Comments

@Scottmitch
Copy link
Member

Are the builds for the static libraries "cleaned" every time? It seems the following commands will run through 2 complete builds of the static libraries:

mvn clean install
mvn install

Is it possible to avoid "cleaning" everything and "rebuilding" every time?

@nmittler
Copy link
Member

possibly ... I'm not sure what LOE this would involve.

@Scottmitch
Copy link
Member Author

are we just blowing away the build artifacts when we FTP new code (or however we get new code)? can the build artifacts follow the typical build phases (mvn clean destroys build artifacts, and otherwise they persist)?

@nmittler
Copy link
Member

are we just blowing away the build artifacts when we FTP new code (or however we get new code)?

If using ftp, probably ... if using the scm plugin (e.g boringssl), not sure.

can the build artifacts follow the typical build phases (mvn clean destroys build artifacts, and otherwise they persist)?

That would be ideal :) ... but sorting this out for each submodule (for both APR and SSL) will require some work.

@Scottmitch
Copy link
Member Author

I think we should restructure the project so the build artifacts are separated from the directories that get FTPed. The configure scripts should support specifying a prefix or build directory right?

@nmittler
Copy link
Member

Which build artifacts are you referring to? APR and SSL? In some cases, we're already creating an install directory (using --prefix when using automake). For ninja-based builds, we'd have to manually copy artifacts, but it's still doable.

@Scottmitch
Copy link
Member Author

Which build artifacts are you referring to?

things that are generated during the build (.o, .a, .class, etc...) that can be inspected by build tools (make, maven, etc..) to avoid re-building if not necessary.

@nmittler
Copy link
Member

so APR and SSL?

@Scottmitch
Copy link
Member Author

APR and SSL

This statement was a bit vague and it was not clear what you were referring to. As long as you are implying the difference between source files obtained via the "get sources" step and the "artifacts generated during the build" step (.o, .a, .class) then yes plus the tcnative artifacts.

It looks like the tcnative artifacts are also regenerated even with no change (not sure if it was like this before though?):

$ mvn install
...
$ ls -al ./boringssl-static/target/native-build/src/.libs/ssl.o
... Feb 24 10:25 ./boringssl-static/target/native-build/src/.libs/ssl.o
$ mvn install
...
$ ls -al ./boringssl-static/target/native-build/src/.libs/ssl.o
... Feb 24 10:36 ./boringssl-static/target/native-build/src/.libs/ssl.o

@normanmaurer
Copy link
Member

This was fixes by #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants