From 2d0f5c7b4f23767976c87c03ad6b62aa85c28167 Mon Sep 17 00:00:00 2001 From: Norman Maurer Date: Mon, 22 Apr 2024 01:01:13 +0200 Subject: [PATCH] Stop cancelling build matrix when one build fails (#868) Motivation: Motivation: We unfortunately have a number of flaky tests haunting our builds. The GHA build matrix will by default cancel all matrix jobs when one job experiences a failure. This is unproductive with flaky tests, because the more failed builds that need to rerun, the higher the chances of more failures. Also, seeing builds pass on other JVM versions helps build confidence, even if other versions failed on a flaky test. Modification: Disable fail-fast on matrix-strategy builds. Result: Jobs in a matrix build no longer get cancelled if a sibling-job fails. --- .github/workflows/ci-pr.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci-pr.yml b/.github/workflows/ci-pr.yml index 08d19f69..18161ecd 100644 --- a/.github/workflows/ci-pr.yml +++ b/.github/workflows/ci-pr.yml @@ -17,6 +17,7 @@ jobs: build-pr: runs-on: ubuntu-latest strategy: + fail-fast: false matrix: include: - setup: centos6-x86_64