Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Clarify some return values around paths and files of zipFunction #1099

Open
danez opened this issue Jun 2, 2022 · 0 comments
Open

Clarify some return values around paths and files of zipFunction #1099

danez opened this issue Jun 2, 2022 · 0 comments
Labels
type: chore work needed to keep the product and development running smoothly

Comments

@danez
Copy link
Contributor

danez commented Jun 2, 2022

Comes from #1098

While working on the above PR, there was some confusion about naming and/or the content of certain properties that are returned by zipFunction. In detail what is inputs, srcFiles and includedFiles? The included nodejs bundlers also slightly differ in what they include in the srcFiles property.

Once we get back to this it might make sense to ...:

  • Get a clear understanding what is returned by each of these properties.
  • What the value of these properties is actually used for (maybe we can merge some?)
  • Maybe the content is fine, but we need better names?

includedFiles was added in the PR above to enable watching files that are manually added to bundles via the config included_files.

@danez danez added the type: chore work needed to keep the product and development running smoothly label Jun 2, 2022
@danez danez changed the title Clarify some return around paths and files of zipFunction Clarify some return values around paths and files of zipFunction Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

No branches or pull requests

1 participant