Skip to content

feat: support custom response headers #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2022
Merged

feat: support custom response headers #51

merged 4 commits into from
Aug 10, 2022
+17 −2

Conversation

ericapisani
Copy link

  • Update README instructions on developing locally
  • Update example project with what custom response headers could look like. The data structure used is the same format expected from custom headers specified within a netlify.toml in a project

Testing instructions:

  • Run the example app
  • In some of the image requests, you should be able to see the HSTS and X-Test headers being set in the response

@ericapisani
feat: support addition of custom response headers
9d68bb8
@ericapisani
refactor: change logic to accomodate use of netlify custom headers
eecb8c5 
Previously was planning on using environment variables within netlify.toml of project.
@ericapisani ericapisani added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 10, 2022
@ericapisani ericapisani requested a review from a team August 10, 2022 17:26
@ericapisani
style: lint issues
7d9b900
@ericapisani
test: commit tarball
5229135 
committing this in order to test in a staging environment in the context of another project
ascorbic
ascorbic approved these changes Aug 10, 2022
View reviewed changes
Copy link

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@kodiakhq kodiakhq bot merged commit 857eb75 into main Aug 10, 2022
@ericapisani ericapisani deleted the ep/support-custom-response-headers branch August 10, 2022 19:04
@token-generator-app token-generator-app bot mentioned this pull request Aug 10, 2022
Merged
@ericapisani ericapisani mentioned this pull request Aug 11, 2022
Merged
2 tasks
kodiakhq bot pushed a commit to opennextjs/opennextjs-netlify that referenced this pull request Aug 12, 2022
@ericapisani @nickytonline @ascorbic
feat: support custom response headers on images served via IPX (#1515)
40cb8a9 
* feat: support custom response headers in image handler

Depends on netlify/netlify-ipx#51

* test: install ipx package in dev

includes the changes needed to support custom response headers

* chore(deps): upgrade ipx package

this version contains changs for supporting custom response headers

* test: add test coverage

* style: run lint

* docs: add info on custom response headers

* fix: address CR comments

* Update test/helpers/utils.spec.ts

Co-authored-by: Matt Kane <matt.kane@netlify.com>

Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
Co-authored-by: Matt Kane <matt.kane@netlify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic

Assignees
No one assigned
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericapisani @ascorbic