feat: write granular info into skip file #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: feature
Merged
2 tasks
ascorbic
approved these changes
May 18, 2022
| reporter.info(`[gatsby-plugin-netlify] No Netlify functions needed. Skipping...`) | ||
| await writeFile(join(program.directory, `.cache`, `.nf-skip-gatsby-functions`), ``) | ||
| } | ||
| const skipFilePath = join(program.directory, `.cache`, `.nf-skip-gatsby-functions`) |
There was a problem hiding this comment.
It's a little confusing that the skip file sets the value "true" when it shouldn't be skipped, but that's probably fine for an internal API, and I can see why it's needed for backwards-compat
There was a problem hiding this comment.
Yep, I went round in circles with this one for a while! As you mentioned, for backwards-compat I ending up settling on this approach because I didn't want to rename the skip file and it was confusing to negate the values in netlify-plugin-gatsby when checking if a function should be bundled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports allowing API, SSR and DSG functions to be disabled individually by reporting which functions are needed in the skip file generated by the plugin.
The change maintains backward compatibility by ensuring that no skip file still indicates all functions are needed.