Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Cypress tests on Firefox are failing #714

Open
ehmicky opened this issue Feb 14, 2022 · 0 comments
Open

Cypress tests on Firefox are failing #714

ehmicky opened this issue Feb 14, 2022 · 0 comments
Labels
type: bug code to address defects in shipped code

Comments

@ehmicky
Copy link
Contributor

ehmicky commented Feb 14, 2022

Cypress tests on Firefox are currently failing.
The following PR is skipping them, but we should re-enable them: #715

They started failing with the following PR: #691. The problem seems to be related to using dependencies using pure ES modules, not to p-filter. I based this statement from some debugging where I tried to upgrade p-locate first instead (#692), and the result was the same.

Also, this appears to be a problem only with our tests. In production, Firefox works well with framework-info.

Finally, this is not a problem with using pure ES modules in framework-info itself, since we migrated to ES modules before upgrading p-filter and the tests on Firefox were successful.

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

1 participant